Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wind power curves to ATTRIBUTION file #131

Merged
merged 1 commit into from
Jan 12, 2021
Merged

Conversation

rouille
Copy link
Collaborator

@rouille rouille commented Jan 8, 2021

Purpose

Add attribution for wind power curves

Where to look

ATTRIBUTION file

Time estimate

5 min

@rouille rouille added documentation Documentation related to package data intake Use of external data labels Jan 8, 2021
@rouille rouille added this to the Good Riddance milestone Jan 8, 2021
@rouille rouille requested a review from danielolsen January 8, 2021 06:45
These datasets are generously provided by NREL, which is operated for the U.S. Department of Energy by the Alliance for Sustainable Energy, LLC. Before using these datasets, please read [this disclaimer][nrel_disclaimer] first.
These datasets are generously provided by NREL, which is operated for the U.S. Department of Energy by the Alliance for Sustainable Energy, LLC. Before using these datasets, please read [this disclaimer](https://www.nrel.gov/disclaimer.html) first.
Copy link
Contributor

@danielolsen danielolsen Jan 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you like this link style more than the other one?

Copy link
Collaborator Author

@rouille rouille Jan 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No but I like consistency and it was the only link that was defined this way.

ATTRIBUTION.md Outdated
* Location: ***prereise/gather/winddata/data/PowerCurves.csv***

##### General Purpose
The dataset is used to generate wind profiles.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wind profile -> wind power profiles from wind speed profiles?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Contributor

@danielolsen danielolsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@rouille rouille merged commit 83aeba5 into develop Jan 12, 2021
@rouille rouille deleted the ben/attribution branch January 12, 2021 17:58
@ahurli ahurli mentioned this pull request Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data intake Use of external data documentation Documentation related to package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants